fix(gcpappengineservice): use metric.response_code in ErrorRate golden metric#3085
Open
sparsi17 wants to merge 1 commit into
Open
fix(gcpappengineservice): use metric.response_code in ErrorRate golden metric#3085sparsi17 wants to merge 1 commit into
sparsi17 wants to merge 1 commit into
Conversation
…n metric GCP metric label attributes are stored in NR with a metric. prefix. The ErrorRate query filtered on response_code (bare) which matched every row (null NOT LIKE '2%' = true), producing a false 100% error rate. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
entityBot
requested changes
Jul 22, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metric.prefix (e.g.metric.response_code)ErrorRategolden metric filter used the bare attributeresponse_code, which is always null ongcp.appengine.http.server.response_countmetricsnull NOT LIKE '2%'evaluates totruein NRQL, so every row matched the "error" filter → false 100% error rate displayed on all App Engine entitiesWHERE response_code NOT LIKE '2%'→WHERE metric.response_code NOT LIKE '2%'Root cause verified
Confirmed via live NRDB query on account 10516273 (staging), App Engine entity
default(projectbeyonddev-193118):metric.response_code = '200'Test plan
FACET metric.response_codeongcp.appengine.http.server.response_countreturns real response code valuesgcpSamplequeries (legacyGcpAppEngineServiceSampleuses bareresponse_code— different schema)🤖 Generated with Claude Code